-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
lint check #2736
lint check #2736
Conversation
Thanks @hannesa2 , this is a good step after merging the modularization into master, I will put it inside new architecture epic |
Why not now ? |
Many changes have taken place during modularization, a bunch of new files have been created, old files have been removed. If we move forward the lint check before merging modularization we could have lint suggestions that are already solved. I'd rather include lint check and start fixing the suggestions after the huge structural change of modularization. Besides, the modularization merge into master should not take long, the last PR is ready to code review => #2728 |
Interesting point of view. Knowing this, there are two ways: To be honest, that's cheeky |
To sum up, I do not want to delay more the modularization merge into master and merging this PR before will block it, since the modularization build will fail because of lint errors (see below) and no modularization merge will be possible till fixing the lint errors. Therefore, just after merging the modularization into master, we will enable the lint check via this PR y start to work on it (I will do it, no problem). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will be continued on #2750 |
To improve code quality, I recommend a lint check on every pull request.
Currently it's obvious disabled, because on master it fails ! Please enable lint check on CI
With this pull request you see in root the lint report
lint-app-report.html
Btw, a lot of them should be solved later on, and after that step, you should prevent them in the future by
severity="error"
in lint.xml